bitcoincore.org icon indicating copy to clipboard operation
bitcoincore.org copied to clipboard

Commit built html

Open achow101 opened this issue 4 months ago • 8 comments

Implements #1162

It turns out the build was not entirely deterministic as the build time and timezone of the building machine would be included in several places. The first several commits makes it so that those timestamps use the commit timestamp.

After including all of the generated HTML, the CI is changed to check that it replicates the HTML that is in the repo.

Lastly, the build has had a deprecation warning which is resolved in the last commit. No HTML changes to fix that warning.

achow101 avatar Aug 13 '25 23:08 achow101

utACK f8cbde6f632d9dd4b46703e0923064e4649755ff

what could go wrong

katesalazar avatar Aug 24 '25 20:08 katesalazar

Determinism is nice. What would we need to do differently before we open a PR?

glozow avatar Oct 29 '25 18:10 glozow

What would we need to do differently before we open a PR?

Just building the site and committing the result. Can be done easily with make.

achow101 avatar Oct 29 '25 19:10 achow101

Can you write a doc for it, e.g. in CONTRIBUTING.md?

glozow avatar Oct 29 '25 19:10 glozow

Can you write a doc for it, e.g. in CONTRIBUTING.md?

Done.

Also rebased.

achow101 avatar Oct 29 '25 22:10 achow101

Am I understanding correctly that if I checkout this PR, and run make build, there should be no diff generated? As that currently isn't the case.

fanquake avatar Oct 30 '25 10:10 fanquake

Am I understanding correctly that if I checkout this PR, and run make build, there should be no diff generated? As that currently isn't the case.

It's supposed to. What does your diff look like?

achow101 avatar Oct 30 '25 15:10 achow101

I think the non-determinism was because of sort order for posts made on the same date. Latest push should fix that.

achow101 avatar Oct 30 '25 18:10 achow101