Ava Chow
Ava Chow
The issue with creating a legacy-sqlite wallet should be fixed now.
> `-legacy` argument shouldn't be removed from `bitcoin-wallet`/ `wallettool.cpp`? (leaving `-descriptors` `true` by default): Good catch! Added a commit to disable legacy wallet creation from the wallet tool.
> If a user tries to restore a legacy wallet (using RPC or QT) setting "load_on_startup" (can't be done on QT but it's being set in the wallet interface code),...
ACK 95a0104f2e9869799db84add108ae8c57b56d360
~0 I've read through the conversation but I still don't understand why this change is beneficial? This is also a major breaking change and would break a significant amount of...
Although the BIP is still in Draft status, I think it should have been marked as proposed or final a long time ago as it does appear to be deployed...
> he's only unresponsive on GH, if BIP2 is followed and email sent, he'd resurface imo (as last time) https://github.com/bitcoin/bips/pull/1600#issuecomment-2150861263 and https://github.com/bitcoin/bips/pull/1600#issuecomment-2191817502 suggests that email was in fact tried, multiple...
ACK 33a28e252a7349c0aa284005aee97873b965fcfe
In 8f2078af6a55448c003b3f7f3021955fbb351caa "miner: timelock coinbase transactions" I'm having a hard time understanding why `rbf_tests.cpp` and `mempool_package_rbf.py` are changed? These are not hardcoded txid changes. Rather the specific changes suggest to...
ACK a58cb3b1c12c8cb75a87375c50f94c4605bb805d