Ava Chow
Ava Chow
> Also we could ask people who graduated CS recently whether their curriculums encompassed Autotools and/or CMake (not an evidence, rather a hint). We handmade our Makefiles...
Thread safety warnings are fixed, not seeing the wallet_transactiontime_rescan.py failure.
> `wallet_transactiontime_rescan.py` only fails for me with configuring `--without-bdb`. This appears to fail on master as well.
> Looks like you got rid of `AddDescriptorKeyWithDB`, but it's still defined in header Fixed > Also the original function contained an assert for not having `WALLET_FLAG_DISABLE_PRIVATE_KEYS` and it would...
> Building throws a warning, because #25642 marked it as such. > > ``` > wallet/keyman.cpp:96:9: warning: ignoring return value of function declared with 'nodiscard' attribute [-Wunused-result] > ext_key->Derive(*ext_key, i);...
Pushed two small changes. The first is to set `WALLET_USES_KEYMAN` for all newly created wallets to avoid any possibility of attempting to upgrade a wallet when it shouldn't. The second...
On second thought, I've removed the last client check. It doesn't quite make sense to have that.
ACK e763496caab2f9b9f9ba038f7a020caa56997c1b
ACK 4fef5344288e454460b80db0316294e1ec1ad8ad
ACK 3693771b9aef4e23a1b92b2c52b19ad44dac75da