Ava Chow
Ava Chow
A few people (@darosior, @glozow) mentioned at last week's IRC meeting that they'd like to have more time to think on this and we'd punt another week. If you have...
Maybe also add a BDB only test that a when a loaded wallet is migrated, it is loaded after migration?
ACK 589ed1a8eafe1daed379ebb383602c8f220aef19
The `CHECK_NONFATAL` is correct. `complete == true` means that the PSBT is complete and can be finalized. The invariant here is that `complete == true` means `FinalizeAndExtract` must succeed. BIP...
A test is definitely necessary here to avoid future regressions. @rkrux's proposed test would be fine. The commit message has a duplicate line that needs to be removed.
ACK dda90a96bd01e34f4a564fbd15f1948f1c22ff58 Nice find! > external non-ranged descriptor MUST be able to have label (current impl disallows it) Since we already have a test for this and this PR doesn't...
ACK 664657ed134365588914c2cf6a3975ce368a4f49 > passes as the bug does not manifest if "internal" is not provided by user I see. Can you mention that in the PR description? > re-based on...
IIRC, Raspberry Pi OS only started shipping 64-bit OSes a couple of years ago. For a while, you could buy a Pi 3 or 4 which had 64-bit hardware but...
ACK 3bdff9a154733f8f9f379448f5595a2e90474bc6
ACK 01cc20f3307c532f402cdf5dc17f2f14920b725b