Ava Chow comments

Results 1080 comments of


                                            Ava Chow

BIPs for MuSig2 derivation, descriptors, and PSBT fields

> It would be great if at least a first test vectors could be added. Given that there are still a few active questions and some things may still end...

BIPs for MuSig2 derivation, descriptors, and PSBT fields

Updated with assigned numbers

BIPs for MuSig2 derivation, descriptors, and PSBT fields

> and given that duplicate pubkeys are AFAIK of no practical value, `musig()` key expressions should perhaps explicitly forbid repeated pubkeys. Added a sentence for that. > It’s not clear...

Improve user dialog when signing multisig psbts

Closing this as it has not had any activity in a while. If you are interested in continuing work on this, please leave a comment so that it can be...

test: Embed univalue json tests in binary

ACK faf7eac364fb7f421a649b483286ac8681d92b31

refactor: std::span compat fixes

ACK fa494a1d53f3f030fafe7b533d72b2200428a0fd

miniscript: account for all `StringType` variants in `Miniscriptdescriptor::ToString()`

ACK 28a4fcb03c0fb1cd5112eca1eb36dcb13e0b4ff2

Please make a new release

Sorry, I meant to do that a few weeks ago but saw that CI started failing again. I would like for CI to be working before making a release, but...

BIP174: Specify PSBT_IN_PREVIOUS_TXID serialization order

"Little endian" is ambiguous; I've used "little endian" to describe the byte swapped form that is displayed to users. The byte order is the same as everywhere else in Bitcoin...

Added rescan option for import descriptors

> Hello, anything still pending or can now be merged? All PRs must be reviewed prior to being merged. This PR does not have sufficient review, so it cannot be...