Andrew Brown

Results 326 comments of Andrew Brown

I'm positive toward this change but someone more familiar with RISC-V should probably review this?

Sure, I can put this on the TODO list but no promises about when I get to it!

This made me think maybe we want to update this naming in wasi-sdk: https://github.com/WebAssembly/wasi-sdk/pull/459?

I already did... where _did_ that commit go?

Oh, one last comment: @ArcaneNibble, as I reviewed this, I noticed that the recent #522 modifies the expected files so we can't merge this as-is. Can you rebase or merge...

The `cargo vet` situation is a bit much: ``` cargo vet diff zstd-safe 5.0.1+zstd.1.5.2 5.0.2+zstd.1.5.2 gyscos zstd 2 files changed, 4 insertions(+), 4 deletions(-) cargo vet diff zstd 0.11.1+zstd.1.5.2 0.11.2+zstd.1.5.2...

I think [51930fa](https://github.com/bytecodealliance/wasmtime/pull/9234/commits/51930fa31b8053b17e9a856fac4c89a98a96bb80) and [da1f467](https://github.com/bytecodealliance/wasmtime/pull/9234/commits/da1f467d805909464102a1134464134e147be21d) have unintentionally updated some crates. Can you remove those commits?

At this stage (after df11990) the fuzzer will trigger an `unimplemented!` failure [here](https://github.com/bytecodealliance/wasm-tools/blob/8c3346e72d3f5100ed80db2e44e326873a9d2443/crates/wasm-mutate/src/module.rs#L46): ```console $ cargo +nightly fuzz run run ... thread '' panicked at crates/wasm-mutate/src/module.rs:46:18: not implemented note: run...

@fitzgen, as I revisited this PR, I realized that I wanted to add several missing bits as well as split several of the commits into separate PRs. Since I've substantially...

Ok, I've removed the last commit and added others that allow this to reach at least 200K fuzz iterations locally. This PR still does not generate shared function bodies but...