Andrew Brown comments

Results 326 comments of


                                            Andrew Brown

ci: add `clippy` results to GitHub code scans

One other comment: my recollection is that we limit our clippy lints to allow or deny only because of the lack of visibility into warnings. My take is that, beyond...

ci: add `clippy` results to GitHub code scans

Any suggestions on a clippy lint to enable to check the GitHub PR interaction?

ci: add `clippy` results to GitHub code scans

I think what may be going on here is that, since warnings are upgraded to errors, the clippy task will just fail.

Add `version.h` defining `WASI_LIBC_VERSION`

CI error should be fixed in #535.

Add `version.h` defining `WASI_LIBC_VERSION`

> Won't this means that the version reported in the wasi-libc that is embedded in wasi-sdk is always at least one version behind because the building happens before the tagging?...

Add `version.h` defining `WASI_LIBC_VERSION`

I'm not working on these currently... closing.

Some `SO_*` constants like `SO_BROADCAST` and `SO_LINGER` aren't defined

This makes sense; are you interested in adding these? (cc: @badeend, @dicej)

getsockopt, setsockopt doesn't implement SO_RCVTIMEO,SO_SNDTIMEO for wasi:socket handles

cc: @badeend, @dicej

fcntl doesn't implement O_NONBLOCK for wasi:socket handles

@dicej, is this still an issue?

Allow non-canonical type alignment?

Well, the `list` would "overallocate" when used with smaller types and certain unaligned sizes (e.g. passing 42 bytes of `u8` would result in 6 extra bytes allocated... with zeroes?). This...