Andrew Brown

Results 257 comments of Andrew Brown

Ah, I see. I would have expected `0x...` to parse as hex values and un-prefixed numerics to parse as decimal values. > For values that do not begin with 0,...

(Wow, have I been working on Cranelift this long?!?). Thanks for asking the question; it took took me down memory lane, though I will say some things are now hazy....

> Also, do you want to open a new PR for cherry-picking https://github.com/bytecodealliance/wasmtime/commit/2d466370db3585f0ed78131c48cd672817d3b47a to remove LoadXmmConst? Sure, https://github.com/bytecodealliance/wasmtime/pull/4876.

Hey, I had completely forgotten about #3251 but I believe when I added [`allowed_instructions`](https://docs.rs/wasm-smith/0.11.1/wasm_smith/trait.Config.html#method.allowed_instructions) to `wasm-smith` it was motivated in part by that issue. The idea would be to configure...

Hm... how? I wasn't really aware of the limitations on function signatures.

Or the first instruction dictates what locals _must_ be available which should bubble up to the signature... This is the part that I'm having trouble seeing in wasm-smith. It doesn't...

Ok, how about this: we add `SingleFunctionModule` to `wasm-smith` which takes a `Config`, an `Unstructured`, and a `Signature`. The `Signature` could be something like: ``` pub struct Signature { params:...

So you mean "arbitrary list of parameters" not "arbitrary list of parameter types"?

@alexcrichton, should the resolution of this just be to return an error if no `Store` (and thus `ResourceLimiter`) are available? E.g.: ```rust if new_byte_size > max { if let Some(store)...

Hm. I had originally thought that a) the `ResourceLimiter` would have to be disconnected from a `Store` or b) the shared memory would have to be associated with a store--neither...