Andrew Brown
Andrew Brown
All right, I'm marking this ready for review with some caveats that I think should be addressed in subsequent PRs. At this point, the PR provides a new interface for...
Oh, one other point: I have gone back and forth a few times about how to design the interface and today, at least, I'm leaning towards merging the `DiffEngine` and...
Ok, I've rebased this PR and included some work @alexcrichton and I did today to adapt the fuzz target to his comments above (thanks @alexcrichton!). There are still some TODOs,...
@alexcrichton, thanks for all the help reviewing this and reworking some of the bits!
cc: @fitzgen?
Just for the record, I am working on x64's `icmp`, `fcmp` and `select` instructions.
I'm looking at loads and stores next, FYI.
Well, I haven't started stores yet... so take them if you want to!
@cfallin, @bnjbvr, I think this almost wraps up what I had proposed in #1385. Several caveats: - I chose to not replace all of the `ctx.emit(PXOR...)` uses with `ctx.emit_constant([0; 16]...)`...
(And apparently CI will fail until I figure out the `LowerCtx::get_constant` and `LowerInput::constant` issues: do we want to go down the route to remove those?)