Andrew Brown
Andrew Brown
Ok, I'm fine with that as well; we can leave this issue open and when someone _really_ needs it then we can just add it.
Interesting; with [`wasi-sdk-20+threads`](https://github.com/WebAssembly/wasi-sdk/releases/tag/wasi-sdk-20%2Bthreads) is the "build wasi-libc again" step necessary any more? On a slightly different note, I want to propose a perhaps controversial opinion: why don't we just build...
I checked this issue again with your suggestion but this is the error I see: ```console $ CC="$WASI_SDK_DIR/bin/clang -pthread --sysroot=$WASI_SDK_DIR/share/wasi-sysroot -Wl,--import-memory --target=wasm32-wasi-threads" ./build.sh Compiling testsuite/thread_spawn-simple.c testsuite/thread_spawn-simple.c:1:10: fatal error: 'assert.h' file...
Huh, this is weird: `/opt/wasi-sdk/wasi-sdk-20.0/share/wasi-sysroot/include/assert.h` is definitely a file and it looks like it has all the right C code. [fiddles around] Ok, I think I see the problem. Somehow...
CC-ing @lukewagner who may have an opinion about this issue. If wasi-threads is defined as a core module, should it use WIT's `result` type? Related: do you foresee that WIT...
I've looked into this a bit more and it seems highly unlikely that we will be able to trigger perf to measure hardware events (e.g. instructions retired) using tracepoints. I...
I don't think we can actually merge this. Once I removed nightly from CI we get failures related to the precision crate missing something on Windows.
What about something like the following: ``` trait BenchmarkExecutionStrategy { fn execute(&self) -> Result; } struct SameProcess(...); // Maybe wrap up `BenchmarkCommand` here? Or an intermediate struct? struct MultiProcess(...); struct...
Not sure this worked?
Maybe something weird is going on with CI: I can see the task you linked to seems to have passed and the build environment that is emitted has the correct...