Andrew Bayer
Andrew Bayer
/approve Good by me!
Yeah, I've seen this pop up but haven't reproduced it myself (though I'm running `update-codegen.sh` on my new M1 for the first time as we speak, so maybe I'll see...
/hold Until I add an example test. =)
/hold cancel @afrittoli I agree - #6061 may also make sense to backport.
> it seems some changes are needed in the validation: `"validation.webhook.pipeline.tekton.dev" denied the request: validation failed: invalid value: parameters of type array only are allowed in matrix: spec.pipelineSpec.tasks[2].matrix[browser]` Oh my,...
Ok, I have a fix for the validation that I'm fairly happy with, but the next problem is that by the time `GetNamesOfTaskRuns(pipelineRun.Status.ChildReferences, pipelineTask.Name, pipelineRun.Name, pipelineTask.GetMatrixCombinationsCount())` gets called within `ResolvePipelineTask`,...
I've updated the PR with my fix for the validation issue, and with a unit test tweak to use an array result as a matrix parameter, to make it easier...