Andrew Bayer
Andrew Bayer
Also worth mentioning that each of the "failed" PRs were created after they switched to `alpha`, though not every "valid" PR was created before then. Valid PRs were created both...
A little more detail on that: the `enable-api-fields` flag was set to `alpha` at 19:21:45 UTC, and all the `PipelineRun`s with self-referential params/results were creating over the next ~13 minutes,...
Ah-ha! I've got it! With 0.35.1, this test fails with the stack overflow: ``` func TestInfiniteRecursion(t *testing.T) { names.TestingSeed() prs := []*v1beta1.PipelineRun{parse.MustParsePipelineRun(t, ` metadata: name: test-pipeline-run-different-service-accs namespace: foo spec: params:...
@RafaeLeal confirmed it - `enable-api-fields` was set back to `stable` at 19:36. We've definitely found what the problem was, and it doesn't exist in v0.36.0 and later. I'm not going...
@RafaeLeal Good question. I'm honestly not sure why we weren't already failing for that...
I'm pretty sure I already did, lemme check.
Yup, I did. =)
/assign @vdemeester @dibyom cc @chitrangpatel
/test check-pr-has-kind-label
/hold Putting this on hold until we've got v0.38.0 cut, 'cos I'd really like to have all of the relevant commits in one release together.