tektoncd
Skip `last-applied-configuration` annotation when merging them.
Changes
When merging annotations from Pipeline and PipelineRun (as well as Task and TaskRun), we are merging everything, even annotations that might not be useful/related and consume too much data on the PipelineRun.
kubectl.kubernetes.io/last-applied-configuration is such an annotation. It is there when a user uses kubectl apply on a Pipeline, and shouldn't be merged into a PipelineRun referencing this Pipeline.
Signed-off-by: Vincent Demeester [email protected]
This is related but independent of #6127 👼🏼
/kind bug
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
- [ ] Has Docs included if any changes are user facing
- [x] Has Tests included if any functionality added or changed
- [x] Follows the commit message standard
- [x] Meets the Tekton contributor standards (including functionality, content, code)
- [x] Has a kind label. You can add one by adding a comment on this PR that contains
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep - [x] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
- [ ] Release notes contains the string "action required" if the change requires additional action from users switching to the new release
Release Notes
Skip `kubectl.kubernetes.io/last-applied-configuration` annotation when merging them in `PipelineRun` and `TaskRun`.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: abayer, lbernick
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [abayer,lbernick]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
