Andrew Bayer
Andrew Bayer
/approve Looks good to me!
/test pull-community-teps-lint
So the failure is definitely because the various fields (in this particular case, `acceptMergeRequestOnSuccess`, but it'd probably apply to any of them) don't have `get*` methods. This is probably barfing...
fwiw, I tend to think this is worthwhile - EC2, OpenStack Nova and CloudStack all have a launch time (or created time) field. It would need to be Nullable, given...
What confuses me is that I've never seen this happen with my own slaves with root as the Jenkins user...and we're definitely not passing any such flag to AdminAccess.
Yes, this is initially failing - but I wanted to toss it up anyway.
@svanoort Fair point. =) Marking as WIP.
@jglick I get what you're saying. You can do `lock(...)` in `options` already, but that applies across the whole build. I suppose I can try to find a way to...
@dolphy01 When using the `lock(...) {...}` step, all locks will automatically be released when either the block is completed or the build fails/is killed/whatever.
@dolphy01 Aaaah - yeah, with the current code here, you do need that explicit `releaseLock()` call, but I think I'm going to add a `RunListener` to auto-cleanup any unreleased locks...