Andrew Bayer
Andrew Bayer
`Run` controllers will need to implement cancellation regardless, so there's a certain logic to just requiring cancellation support and having the `PipelineRun` reconciler handle `PipelineTask`-driven timeouts. But both because that's...
/priority important-soon Since we haven't even yet moved to k8s 1.22 minimum, I don't think we can bump straight to 1.23 in v0.39. Maybe v0.40?
Related knative/serving issue - https://github.com/knative/serving/issues/12806. Looks like Knative will be moving to k8s 1.23 as minimum version in October: https://github.com/knative/community/blob/main/mechanics/RELEASE-SCHEDULE.md. Whether that's a blocker for us moving to requiring 1.23,...
I'm in favor of this approach. It does kinda feel like it deserves a TEP, but it's borderline to me.
/assign
I can't reproduce this - deletion went through right away for me...
@chuangw6 Aaaaah - that's fixed in #5215.
I was looking at the webhook logs, which is where I saw the conversion errors. Could you post your new webhook log with latest main?
Aaaah, I see https://gist.github.com/chuangw6/c1907a1d1f10a2962e9718b0c21ca4fd#file-pipeline-webhook-log-L342 - that's a problem for sure, but it's fixed in #5210.