Andrew Bayer
Andrew Bayer
> Unfortunately, there are no unit tests for `skip`, `skipBecauseWhenExpressionsEvaluatedToFalse`, `skipBecauseResultReferencesAreMissing`, etc. True, but they are actually well-covered by the tests for `Skip` - I checked. =)
/hold > I don't mind merging this change but I haven't got chance to run any additional tests. I'd actually like to hold it a bit - I think I...
/test check-pr-has-kind-label
Closing this because I am 99% sure I figured out the problem in https://github.com/tektoncd/pipeline/issues/5271#issuecomment-1218341861, and this is not the way to prevent the scenario caused by the now-removed implicit parameters...
So `git-init` is tested in https://github.com/tektoncd/pipeline/blob/2b8538214169ec1c3af14221f44ea59e6b1b81f7/test/yamls/v1beta1/pipelineruns/pipelinerun.yaml#L83 - and it was updated in #4758 with the `runAsUser: 0` change. So that issue slipped through not because it wasn't being tested but...
I don't think we want to stop running everything in `examples`, since we should definitely be sure that any of the examples we're showing to users actually work, but adding...
Yeah, I think so. /lifecycle freeze
Whoops /lifecycle frozen