Yanzhao Wang （王彦昭）
Yanzhao Wang （王彦昭）
> That said, we maybe should put some if(fSink) { fSink->Close(); } (and the same for fSource) in FairRun::~FairRun? Yes, but just `fSink->Close()`. I don't understand what's the purpose of...
> Just one next thought: > > > > Calling `Close` from dtor of FairRun means that FairRunSomething doesn't any longer exist (because its dtor has already ran). It only...
@ChristianTackeGSI Something wrong in CI? I got an error saying cmake version is too old in CI machine. > CMake Error at CMakeLists.txt:8 (cmake_minimum_required): CMake 3.18 or higher is required....
Thanks very much for your comment. > The "at the end of the run" argument. If you want to do anything at the end of the run, what about deriving...
Sure, I will check it out. I don't know what's the best way to fix this currently. Closed function should always be used in a dtor with the correct ownership....
> Calling a virtual member function from a constructor doesn't do what you would expect. You mean "destructor" instead? I don't quite understand here. If so, what kind of behaviour...
Yeah, I agree. But would this be a huge breaking change? Many programs would not be terminated in the emergency, which could cause lots of segmentation fault.
Hi, @ChristianTackeGSI I'm trying to use the dev version of FairRoot in R3BRoot. We are still using the MODULE mode to find ROOT, which runs through FindRoot.cmake. In this case,...
Great to hear this change. If using CONFIG mode to find ROOT is preferred, should we just use cmake targets without global variable `${SYSTEM_INCLUDE_LIBRARY}` or `${BASE_INCLUDE_LIBRARY}` that include root include...
Hi Sorry for the late reply. > Right, the idea is to use exported targets from ROOT with their include paths. So one should only need to properly declare dependencies...