Yanzhao Wang (王彦昭)
Yanzhao Wang (王彦昭)
Thanks for the comments. I won't object most of your suggestions. Considering the possibility that clang-tidy can have different configurations under different folders, I assume your suggestions are meant for...
@inkdot7 Have you rebased your PR to the HEAD of the dev branch?
> I very much agree that CI should not automatically change submitted code. In fact, if it is able to modify code inside e.g. a inkdot7-owned repository, I would be...
Hi @ryotani "cognitive complexity" is used to prevent people from creating functions with hundreds of lines of code. The more if and for statements there are, the more "cognitive complexity"...
> readability-identifier-length should be highly context dependent. What is ok in a small scope might not be reasonable in a larger scope. Adding two more letters doesn't really hurt and...
I don't quite get it. What is its advantage compared to directly defining the struct? ```c++ struct MyStruct{ uint_16 fFoo; uint_16 fBar; uint_16 fBaz; }; auto a = Data{}; ```
Alright, maybe we could first see what are the "industrial standards" to serialise or deserialise C++ data structures. As far as I know, the most popular one is google protobuf....
Hi @kresan, could you give this PR a review about the build.py, a build script for R3BRoot, and using parameters without parameter factories?
> From my understanding, the conan dependencies would not be automatically installed if people continued to run cmake, which is why you added the build.py. No really. The conan dependencies...
> I appreciate you trying to separate the ugly FairRoot glue code from code which does actual useful work, but I don't think I am convinced your model can scale...