Yanzhao Wang (王彦昭)

Results 125 comments of Yanzhao Wang (王彦昭)

Yes. Good, then I will proceed this PR very shortly. > So I think, the first step is to make sure that all sinks/sources actually clean up their resources (close)...

@ChristianTackeGSI I have to remove the calling of Close functions in FairRootManager and FairRoot derivatives in this PR. Otherwise, the program is guaranteed to perform the double closing, which may...

Hi, I have made the changes according to your standard. So if there is nothing else, it's ready to be merged.

@ChristianTackeGSI Sorry that I haven't got the time to continue the development of this PR. I will think about this PR next week.

Could it be a better solution that we have a separate git repository for all ext header files and include this separate repository as a git submodule under this repository?...

Dear @inkdot7 I agree. But I'm not sure it's possible to always keep this backward compatibility for all detectors. For NeuLAND, sure, an ext header file with trigger for 13...

> I absolutely would not recommend subjecting our users to git submodules. Why? > A [decent language](https://doc.rust-lang.org/book/ch19-06-macros.html) would prove a way to generate all these by just feeding the onion...

2000 warnings for a PR with 5000+ lines of changes. Both are too big for a PR. But as I have suggested in the last meeting, if you want to...

> "there are many collaborators waiting for this new version" There is a standard way to do this, which, I would guess, is not known by most of our collaborators....

Hi, @michael-heil I don't have any ill intent to your work. I'm very sorry if my comment makes you feel that way. Your contribution to our collaboration is absolute essential....