Yanzhao Wang (王彦昭)

Results 125 comments of Yanzhao Wang (王彦昭)

Hey @jose-luis-rs , CI tests for R3BRoot and glad-tpc have been fixed. Could you merge [the pull request](https://github.com/R3BRootGroup/sofia/pull/314) in the sofia repo and restart the CI test here?

@jose-luis-rs No, I didn't have such an issue. ```c++ TCanvas *c_projection = new TCanvas("c_projection", "c1", 1, 920, 37, 1, 920, 1, 043); ``` I think this is a wrong constructor....

Additionally, this PR also clean the dependency tree a little bit. The old dependency tree is like this: ![r3bbase_mess](https://github.com/R3BRootGroup/R3BRoot/assets/49562465/8b636e1a-f9cb-4ddc-a485-07e5846d9ca6) And after cleaning up, it becomes better with this: ![r3bbase](https://github.com/R3BRootGroup/R3BRoot/assets/49562465/35af8899-9c90-4d8a-9083-48fa52c0e353)

Hi @jose-luis-rs. Have you checked the modifications? Since there are cyclic dependencies between R3BRoot and the sub projects (sofia, glad, etc), the errors in the CI cannot be fixed only...

Thanks @jose-luis-rs But I don't think jan24p1 of FairSoft matters for this PR, as the PR should be backward-compat towards older versions of FairSoft & FairRoot. As you can also...

@jose-luis-rs Thanks. If there are some linking error issues, I will make further quick fixes ASAP.

@klenze ### modernize-use-trailing-return-type I suggest we should keep this feature and make the trailing return type as the default for the upcoming code with following reasons: 1. readability In my...

@klenze I think it's ok to just to write `void SetRange(int range)` and clang-tidy won't complain about it. But it's also ok for me to disable return trailing type. It's...

@klenze @jose-luis-rs Maybe we can discuss the magic numbers here. Currently checks on all floating-point values are disabled. And checks on integers, "0, 1, 2, 3, 4", are also disabled....

@inkdot7 If you have any issues about clang-tidy, you can report here. It's very strange that clang-tidy gives an error while the gcc compiler doesn't. I will look into this...