Greg Korba

Results 540 comments of Greg Korba

Sorry to see this closed 😭. The worst part is currently we can't rely on @julienfalque's work, as currently he has more important private stuff (understandably). Let's mark this PR...

@kubawerlos I am not completely sure if you're right... I mean, what should be more important - fixer's name (its intention, that is unchangeable) or description (that is dynamic and...

I didn't say that description is not important, only suggested that name is _more_ important. Description should extend name's intention, in this case name is not about chaining, so description...

> The thing that confused me the most is that `multiline_whitespace_before_semicolons` worked for all cases up to 3.15 If it worked before, then we should treat it like a bug....

Revisited this and I am going to change this into feature request - neither in v3.15 and current `master` we don't have test case for ensuring semicolon being in new...

Similarly to [$this](https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/issues/7261#issuecomment-1699363077), I don't see it as a bug.

Importing symbols from global namespace is explicitly skipped in `fully_qualified_strict_types`, there is even [test case](https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/blob/75f1b53bd43614dc5942a760073e4b4c639c9955/tests/Fixer/Import/FullyQualifiedStrictTypesFixerTest.php#L563) for that. At this point these fixers are _not_ colliding, but I agree these should...

I was thinking rather about the ability to define `import_symbols` both as `bool` (fully enabled / disabled) or an array with more specific options, where top-level `true` would act as...

The recommended way is mentioned in the readme and the [example of how to do it is shown right below](https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/blob/master/README.md?plain=1#L41-L48). Then you have: > For **more** details and other installation...

@JParkinson1991 the rationale behind it is that your dev tools should not affect your production dependencies. Yes, you can add it to `require-dev` and in most cases you will get...