Greg Korba
Greg Korba
@staabm could you please rebase this PR and resolve conflicts? I can do it too but later (AFK now).
Auto-review tests have to be adjusted. But I believe PHPStan extensions classes have to be placed outside of the `src`, as this is not a production code that should be...
PR looks good to me, we just need to clean up some CI jobs to make this PR green. @staabm yes, baseline must be regenerated as I don't have rights...
FYI: I did an interactive rebase and cleaned up commits a little (kept only meaningful changes).
@staabm Instead of doing classic review I just applied changes I would like to see. Please get familiar with the changes and let me know if you're OK with them...
Thank you @staabm 🍻!
It should be easily possible after #7909 got merged - all attribute items can be collected from any `#[]` and used classes can be imported if needed.
@mvorisek no, #5620 was about phpDoc tags only (`@tag \F\Q\C\N`), not annotations (`@F\Q\C\N`).
From [`doctrine/annotations`](https://github.com/doctrine/annotations): > ⚠️ PHP 8 introduced attributes, which are a native replacement for annotations. As such, this library is considered feature complete, and should receive exclusively bugfixes and security...
IMHO there should be new line before first argument: ```php public function __construct( protected readonly ContainerInterface $locator, protected readonly TranslatorInterface $translator, protected readonly RouterInterface $router) { } ``` There's no...