Greg Korba

Results 540 comments of Greg Korba

I said about `PhpExecutableFinder` in `Config::$phpExecutable`'s context, not in linter's. Where we need to specify PHP executable, we use finder, not config's value. FYI: it was introduced in #1146 and...

@uuf6429 for reference, see [here](https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/discussions/7118#discussioncomment-6356725) and [here](https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/discussions/7312#discussioncomment-8020855). In general, I understand your point and I agree it would be great to be able to decouple Fixer from PHP runtime, but...

IMHO this should be closed. As @fgibaux already [pointed out](https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/issues/8095#issuecomment-2636288783), `resource` is a soft-reserved PHP keyword and should be avoided in userland. Additionally, it's possible to configure `phpdoc_types` and do...

@dantleech the code you pointed is only for default config. By default Fixer uses sequential runner, unless "future mode" is enabled or `PHP_CS_FIXER_PARALLEL` env var is set. If Fixer's config...

It seems like PHP-CS-Fixer/PHP-CS-Fixer#8154 can fix this, as we could fallback to sequential runner automatically if amount of files to analyse is lower or equal to chunk size. This can...

I believe it was introduced in #7023 and I [pointed it out](https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/pull/7023#discussion_r1218078039), but it was merged anyway as it fixed other issues 😅. I agree that this is not an...

@nicolas-grekas because this request is almost 5 years old, please let us know if it's still valid 🙂.

@X-Coder264 could it be related to #8013, or you don't use `--path-mode=intersection`?

> The weird thing is I've tried the parallel runner on another project (that one doesn't use `php-cs-fixer/shim` though, it uses `friendsofphp/php-cs-fixer`) and it's working just fine there so I'm...