Greg Korba

Results 540 comments of Greg Korba

> I can't use functions ? I must put everything in the Fixer class ? Not necessarily in the fixer's class, if this is something to be reused across several...

@jlecordier instead of adding comments with todos, just add test cases - they can fail for now, and PR won't get merged until these are covered. For other todos it's...

> Thanks for the suggestions but can't I have some peace, even on my own PR lmao ? 😭 I get notification for your every self-comment, while editing the description...

@FeBe95 is [`-vv`](https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/pull/7777#issuecomment-2109111690) not enough for you? In general, error handling in child processes is painful, as it's not possible to transmit exceptions (and their trace) from worker to main...

All I see in the linked issue is that you used `-vvv --sequential` which gives native exception from the main process. Parallel runner with `-vv` shows stack traces from both...

Ah OK, now I understand. It's not a worker error (unhandled), but a process error that is caught during the process, serialised on worker's side and reported to the main...

@keradus I believe we should incorporate [`phpstan/phpdoc-parser`](https://github.com/phpstan/phpdoc-parser) and don't reinvent the wheel. It would simplify our codebase so much, no more (or at least less) regexes, only upstream API which...

I believe there's no such rule. With a proper parser (mentioned above) it would be easier, right now we don't handle multiline phpDocs more than regex substitution, if I remember...

@hirasso thanks for the report. Please use `single_space_around_construct` to achieve what you need 🙂. The interesting part is why it's not a part of PSR-2, it's only included in `@Symfony`...

Well, it depends how you want it to work. As for any configurable rule you can use `true` for default config, or you can provide your own, using available options...