Greg Korba

Results 540 comments of Greg Korba

In fact it should return `static` (as the `Config` is not final), but since we support PHP 7.4 it's not possible to use this notation. But it's not that important...

I've reproduced this issue [here](https://phpstan.org/r/549a7b77-2f3f-4869-8f24-551b77d2b40c), and fixed it [here]( https://phpstan.org/r/b151d91f-b5c8-49d7-8d00-3b9eb6be001e) in a BC-compatible(?) way. @petski what IDE do you use? Because I couldn't reproduce the problem in PHPStorm, I only...

I would need to look at it more, because I couldn't get it to work even with PHPUnit/ParaUnit added directly to `dev-tools` requirements: ``` $ vendor/bin/phpunit PHPUnit 10.5.35 by Sebastian...

@javaDeveloperKid please provide expected output, because from the report I just can't tell what's wrong. Used `./php-cs-fixer check --verbose --diff reproducer.php --rules='{"global_namespace_import":{"import_classes":false,"import_constants":false,"import_functions":false},"no_unused_imports":true}'` for your snippet and got: Should it be...

@rtek `DirectoryInterface` is not marked with `@internal` so it would be a BC-break, that's why it's a not a good way to go. There surely is a fix for that...

I reproduced it and it seems like we really don't have [test case](https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/blob/60618e4681ca38edc18ee792225379c570779f7e/tests/Fixer/PhpTag/BlankLineAfterOpeningTagFixerTest.php) for code like your example, with a comment directly after opening tag. `blank_line_after_opening_tag` does not picks this,...

Annotating test methods (or data providers' cases) is nice to have, but outputting basic warning that would be displayed in the workflow's summary is good enough to start with.

@bachinblack yeah, seems like a good place for that 🙂. Standalone fixer would be an overkill.