Greg Korba

Results 540 comments of Greg Korba

I am going to close this because: - the feature request is too generic, it does not provide any information how baseline should work (on file level, file+fixer level, file+fixer+token...

@leofeyer new line before comment can't determine indentation: ```php switch (true) { case 'foo': $foo = []; // Some complex logic foreach ($foo as $f) { } // Some comment...

@c33s what advantage do these comments give? For me it looks disjointed. Also, I don't understand the "as i don't "count" them to the code itself" argument, because in my...

> in a development/research code commented code is very often present and should not be indented But _why_? I totally don't get the reasoning. What's the advantage of non-indented code?...

IMHO it would be a little like promoting messy code, which is against Fixer core concepts. If the IDE behaviour is a problem, and causes `statement_indentation` to indent such commented...

Little update: mentioned rule `single_space_after_construct` is deprecated, you should use [`single_space_around_construct`](https://cs.symfony.com/doc/rules/language_construct/single_space_around_construct.html#rule-single-space-around-construct). It also can handle only space _after_ `:`, but it should be possible to add support for space before...

I am going to close this because: - there was not any interest in this issue for more than a year - we have limited capacity and it's nearly impossible...

@SpacePossum maybe I misunderstood the issue, but AFAIU @DerManoMann wanted to enforce space before `:`, which is against PER-CS. For enforcing no white space between named arg and `:` we...

As you can see there's no clear DoD here, that's another reason for closing this. But OK, let's reopen and add task to the #7247 checklist 🙂.