Greg Korba comments

Results 540 comments of


                                            Greg Korba

FQCN transform for properties

Closing as duplicate of #5004.

Replace `stripos()` with `str_*_with()`/`str_contains()` with `strtolower()`

Personally I would just add it to existing [`modernize_strpos`](https://cs.symfony.com/doc/rules/alias/modernize_strpos.html#rule-modernize-strpos) even though its name would be not 100% correct then. IMHO it does not even require config flag, but could be...

Keep empty line breaks inside control statements

Thank you for taking your time to report this, but unfortunately I'm going to close it since it refers to Fixer's version (2.x) which is not maintained anymore. Feel free...

bug: Fix MultilineWhitespaceBeforeSemicolonsFixer

I see a lot of work has been done here and I believe it's worth finishing. @ossinkine is it possible to rebase this again? @kubawerlos @keradus let's help somehow and...

Require phpdoc/docblock for all functions

I believe after 5 years since initial request it got outdated, considering PHP going more and more into strict types (signatures, properties, even class constants) it does not make sense...

Leading white space is not removed

Closing this, as it's clearly configuration issue and there's no response for almost a year.

feature: PhpdocTo Property/Return/Param Fixer - allow fixing mixed on PHP >= 8

@MortalFlesh is it possible to rebase this PR, so we can check current pipeline result and continue the review process?

feature: PhpdocTo Property/Return/Param Fixer - allow fixing mixed on PHP >= 8

Thank you @MortalFlesh 🍻

`braces` suggests wrong indent on multiline property declaration

Hey! Thanks for your report. We identified that `braces` fixer is too complex and has too many responsibilities. With that, [we decided to deprecate it](https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/pull/4885). That also means that we...

`binary_operator_spaces` problem with several shifts in single line

FYI: reproduced on v3.16.1 with `--rules='{"binary_operator_spaces":{"default":"align_single_space_minimal"}}'`: