Greg Korba
Greg Korba
@bachinblack in general it looks OK for me, but we had discussion about it with @kubawerlos and we think @SpacePossum's approach in #6387 was interesting, to have 2 separate conditions...
@AlessandroMinoccheri it depends 😅 I believe there are scenarios when you would like to have multiple expectations but only one error if any of the expectations is not met (but...
@julienfalque yes, that's the option that would simplify the upgrade process 🙂. I'll look at it and maybe create another PR for that.
@julienfalque I believe we can't get rid of Prophecy just like that because there is whole architecture prepared to ensure `prophesize()` is preferred over mocking ([here](https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/blob/fb7f3523d563406554a3e739ecc98c25b7943867/tests/TestCase.php#L34) and [here](https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/blob/fb7f3523d563406554a3e739ecc98c25b7943867/tests/TestCase.php#L49-L50)). Yet, it's...
FYI: Biggest blockers already resolved, we can start working on our part 🙂
It won't be easy 😩. I was able to change constraints to allow PHPUnit 10 in `phpunitgoodpractices/traits`: BUT the whole idea of that repo is killed by `final` added to...
I've spent some time yesterday on it and here's some additional info: - with `spaze/phpstan-disallowed-calls` it's possible to block `assertEquals()` completely, but it's not possible to do this only for...
FYI: Fixer looks for `.php-cs-fixer.php`, then for `.php-cs-fixer.dist.php` and if none is found, it loads `default` configuration. In your case you can see that was the case too. It can...
FYI: please see #6948 for more context about this.
@kusab85 please rebase the branch or add me to `gdl2studio` org so I can do it and push refreshed code.