Greg Korba

Results 540 comments of Greg Korba

@alcohol Done 🙂 Great news! PS. I did not remove you from review, I just clicked "request re-review" from @ciaranmcnulty 🤷‍♂️

@ngntrgduc Thanks for the great tip! I encountered this issue on my blog, but ignored it as I did not want to spend my time on it, however I've just...

Just FYI: we got similar false-positives for `recode` extension because we had private static method called `recodeSomethingSomethingSomething` (not actual name of course 😆). `PHPCompatibility.Extensions.RemovedExtensions` should take into consideration if called...

@akostadinov it's not a regression, my changes support only `image:tag` format, because without `:` it's impossible to distinguish previous layers' names from images' names. @MetalArend If you use Hadolint and...

@akostadinov You use tag, but also you use `ARG` so `--from` does not contain actual value. Hadolint is a static analyser, AFAIK it can't resolve your variable and run check...

So you can use ```dockerfile ARG PORTA_IMAGE=quay.io/3scale/porta ARG PORTA_VERSION=nightly COPY --from=$PORTA_IMAGE:$PORTA_VERSION /opt/system/config/standalone.sphinx.conf "/etc/sphinx/system.sphinx.conf" ``` and keep full flexibility of use internal repositories, but with `image:tag` format that Hadolint would understand.

@magikid make sure to read [my comment](https://github.com/hadolint/hadolint/issues/859#issuecomment-1449838431) and ensure you use `image:tag` format in your `Dockerfile` 🙂.

If there's `/** @var string */` then it's removed. So you basically want to remove type declaration from phpDoc when additional description is provided, and as an output you would...

@bachinblack hi, thank you for the contribution. From top of my head I can't tell right now if we already had such a fixer, but I'm on vacation now and...

FYI: there is issue #6225 and there was PR #6387 that addresses same concept.