Vincent Langlet

Results 395 comments of Vincent Langlet

> @VincentLanglet Agreed, but how do you test it? Are those even needed? Your example ``` class Exporter { /** * @param ServiceLocator $strategies */ public function __construct( #[TaggedLocator(tag: ExporterInterface::class,...

I fixed all the tests issue in https://github.com/psalm/psalm-plugin-symfony/pull/242, maybe this PR could be rebased after the merge of mine @seferov @Punk-UnDeaD ?

I tried to add ``` public function __construct(string $environment, bool $debug) { $this->environment = $environment; $this->debug = $debug; } ``` inside the stub without success. It's even worst because I...

Sure, https://github.com/VincentLanglet/SonataDoctrineORMAdminBundle/tree/reproducerPsalm can be used.

There is a reproducer here: https://github.com/vimeo/psalm/pull/7075, so I assume it should be fixed in vimeo/psalm

Nope, the issue is still here.

> Since normalizeOptions method in parent class is a little obscure I don't think psalm itself should be able to handle this but > it can be fixed by the...

> > If it gets merged than sure, if not than I don't see a point in keeping this PR up to date for so long. > > > >...

> This is checked indirectly by other sniffs, that require N lines (defaults to 1) to be between methods in a class. There is missing checks since there is no...