Vincent Langlet

Results 395 comments of Vincent Langlet

For > Method Sonata\PageBundle\Serializer\InterfaceDenormalizer::supportsDenormalization() has parameter $context with no value type specified in iterable type array. You need to add phpdoc. For > Method Symfony\Component\Serializer\Normalizer\DenormalizerInterface::supportsDenormalization() invoked with 4 parameters, 2-3...

@Hanmac there is a `DenormalizerAwareInterface`. Dont you think you should both implement DenormalizerAwareInterface and SerializerAwareInterface ? This will avoid to override the phpdoc of setSerializer and avoid the psalm issue.

> hm where does it want me to do the psalm thing? I would say it's because you're using `\*` and not `\**`

> tests are broken, but not by me What do you mean ? Tests are green

I'll fix it with https://github.com/sonata-project/SonataPageBundle/pull/1527

> Just give a 👍🏼 if you have tested it in some project! I think you're the only one with a project with PageBundle. So we will need you to...

> who create the PR must be responsible to test it! Two testers are better than one. I thought you could tested it with your own personal/work project. I personally...

Sure ! if it can be done with https://github.com/sonata-project/SonataPageBundle/blob/3.x/tests/App/AppKernel.php it's great. More test functional would be a great thing for this project with 58% coverage

@eerison @haivala Do you know something about this ? PR with docs are always welcomed

Havind all the issues in the same issue might be enough