Vincent Langlet

Results 395 comments of Vincent Langlet

For ``` http://localhost:8001/admin/app/sonatapagepage/tree ``` it's the same issue than https://github.com/sonata-project/SonataPageBundle/issues/1498 I proposed a solution.

For ``` form.group_form_page_group_main_label, form.group_form_page_group_seo_label, form.group_form_page_group_advanced_label ``` I assume the translations exists either https://github.com/sonata-project/SonataPageBundle/blob/3.x/src/Resources/translations/SonataPageBundle.en.xliff#L133-L144 or https://github.com/sonata-project/SonataPageBundle/blob/3.x/src/Resources/translations/SonataPageBundle.en.xliff#L225-L236 But SonataAdmin changed the way he generated the translation keys. In 3.x `foo.bar` group were...

For create_snapshot, it's https://github.com/sonata-project/SonataPageBundle/pull/1502 IMHO

> @VincentLanglet have you tried to add this in the pipelines: https://symfony.com/doc/current/translation/debug.html to get the missing translations? It would miss all the translation key generated dynamically if I understand correctly

> * at `http://localhost:8001/admin/dashboard` is returning `An exception has been thrown during the rendering of a template ("The options "manager", "page_id" do not exist. Defined options are: "attr", "extra_cache_keys", "groups",...

> Saw the same error and tried to fix, but didn't found a solution without touching BlockBundle. Seems ok to me to touch the BlockBundle, but I would have prefer...

> I tried to update `get` function on `BlockContextManager` to add (merge) `$settings` to `$block` but I guess we can fix this issue with add `$optionsResolver->setDefaults($settings);` to BlockBundle : [BlockContextManager.php#L285](https://github.com/sonata-project/SonataBlockBundle/blob/45b7547dd6c00b60b76ae63ad08f2c399c67b350/src/Block/BlockContextManager.php#L285)...

> when I'm running composer update -W, I'm facing this issue Compile Error: Type of App\Entity\SonataPageBlock::$page must be ?Sonata\Pa !! geBundle\Model\PageInterface (as in class Sonata\PageBundle\Model\Block) at In SonataPageBlock.php line 16:...

> Really? I don't remember to change something inf Block::page Since we're adding typehint, you'll need to add some too. Composer is asking you to change `$page` to `?PageInterface $page`...

Can you also try https://github.com/sonata-project/SonataPageBundle/pull/1524 @eerison ? Or maybe explaining why we need a custom BlockContextManager. I found no occurence of the `page_id` or `manager` keys.