Vincent Langlet

Results 395 comments of Vincent Langlet

Thanks ! It works perfectly.

Any idea where I should look in the code to try to fix this @ondrejmirtes ?

Ok. It's the following code https://github.com/phpstan/phpstan-src/blob/1.8.x/src/Reflection/ClassReflection.php#L1265 Removing ``` if ($this->stubPhpDocBlock !== null) { return $this->stubPhpDocBlock; } ``` obviously fix the test. I made some try and this is a more...

@ondrejmirtes I can try to solve this one if you know where I should look at in the code

@ondrejmirtes I can try to solve this one if you know where I should look at in the code

I found simpler example that need to be fix first https://phpstan.org/r/ab512def-f3a0-46bf-b8f1-c76d13107c3b works but https://phpstan.org/r/293fe931-e457-40db-8acd-0c5ab62907ca doesn't. And https://phpstan.org/r/5803229b-3964-415c-a5b0-b9fb518bb6d4 doesn't Also https://phpstan.org/r/0248960d-5370-40bc-b4b2-82de2398af2a is not working but https://phpstan.org/r/bd322a43-aa49-48d7-82a1-003b2dac58eb does

> I think this feature seems implemented already [phpstan/phpstan-src#1280](https://github.com/phpstan/phpstan-src/pull/1280) you should enable some options to make phpstan report https://phpstan.org/blog/bring-your-exceptions-under-control I often enable the exceptions checks of phpstan, but always disable...

Started in https://github.com/phpstan/phpstan-src/pull/1636

@ondrejmirtes You added easy fixes. I'll be happy to try, if you can help me about where I should look at.

In the NodeScopeResolver, the Unset case is treated this way: https://github.com/phpstan/phpstan-src/blob/f69886fa030799effad85649ad862ab7dfca43a9/src/Analyser/NodeScopeResolver.php#L1324-L1332 So I think it should be in the `MutatingScope::unsetExpression` method, so it's here: https://github.com/phpstan/phpstan-src/blob/f69886fa030799effad85649ad862ab7dfca43a9/src/Analyser/MutatingScope.php#L3719-L3741 With the test provided, the...