False positive "UninitializedProperty" with Constraint

[VincentLanglet]

The following code

use App\Entity\Foo;
use Symfony\Component\Validator\Constraint;
use Symfony\Component\Validator\Exception\InvalidArgumentException;

class MyConstraint extends Constraint
{
   /**
     * @var Foo
     */
    public $foo;

    /**
     * @var string
     */
    public $message = 'message';

    /**
     * @param mixed $options
     *
     * @return void
     */
    public function __construct($options = null)
    {
        parent::__construct($options);

        if (!$this->foo instanceof Foo) {
            throw new InvalidArgumentException('The "foo" parameter value is not valid.');
        }
    }

    /**
     * @return string
     */
    public function getDefaultOption()
    {
        return 'foo';
    }

    /**
     * @return array
     */
    public function getRequiredOptions()
    {
        return ['foo'];
    }
}

Is returning an error:

UninitializedProperty - Cannot use uninitialized property $this->foo

But the property is initialized in the parent::construct() since it does

$this->$option = $value

Is it something that can be improved in the symfony plugin (and how ?) or should psalm be more careful with the parent constructor ? @seferov @muglug

[seferov]

@VincentLanglet thank you for the report.

Is it something that can be improved in the symfony plugin (and how ?) or should psalm be more careful with the parent constructor ? @seferov @muglug

Since normalizeOptions method in parent class is a little obscure I don't think psalm itself should be able to handle this but it can be fixed by the plugin either stubbing Constraint class returning options as it is instead of any array or using plugin hooks. I need to test it to be sure.

[VincentLanglet]

Since normalizeOptions method in parent class is a little obscure I don't think psalm itself should be able to handle this but it can be fixed by the plugin either stubbing Constraint class returning options as it is instead of any array or using plugin hooks. I need to test it to be sure.

Hi @seferov, did you find some time to take a look ? :)

[seferov]

Hi @VincentLanglet,

I simplified the problem to this https://psalm.dev/r/2d3d231b58

Maybe psalm should handle this case. @muglug what do you think?