psalm-plugin-symfony icon indicating copy to clipboard operation
psalm-plugin-symfony copied to clipboard

Published 20 hours ago • verified publisher icon psalm

Prevent PropertyNotSetInConstructor

Open Punk-UnDeaD opened this issue 3 years ago • 6 comments

Support @reqired annotation and #[Required] attribute for properties. Prevent PropertyNotSetInConstructor when ContainerAwareTrait used.

for #141 and #140

Punk-UnDeaD avatar Feb 12 '21 19:02 Punk-UnDeaD

@Punk-UnDeaD thank you for your contribution. Could you please rebase your branch or merge with up-to-date master to pass the tests?

seferov avatar Feb 26 '21 05:02 seferov

What's the status here, you need some help or anything? CI is failing, so it can't really be expected to be merged in this state.

ostrolucky avatar Apr 13 '21 13:04 ostrolucky

@ostrolucky i fixed all my issues, but tests failed on 'Class 'Symfony\Component\BrowserKit\AbstractBrowser' not found' and i don't know how to skip this

Punk-UnDeaD avatar Apr 14 '21 08:04 Punk-UnDeaD

I fixed all the tests issue in https://github.com/psalm/psalm-plugin-symfony/pull/242, maybe this PR could be rebased after the merge of mine @seferov @Punk-UnDeaD ?

VincentLanglet avatar Jan 29 '22 10:01 VincentLanglet

Just a heads up: There already is a handler for the annotation in src/Handler/RequiredSetterHandler.php. Shouldn't that be removed in favor for this solution?

MisatoTremor avatar Jun 21 '22 12:06 MisatoTremor

Any progress on this?

aurimasniekis avatar Jul 20 '22 12:07 aurimasniekis