Valentin Vignal
Valentin Vignal
@chunhtai would you want to have a chat about it? How should we proceed?
@chunhtai Thank you, I'll look at it
I've added ```diff bool _handlePopPage(Route route, Object? result) { final Page page = route.settings as Page; final RouteMatchBase match = _pageToRouteMatchBase[page]!; - return widget.onPopPageWithRouteMatch(route, result, match); + final bool didPop...
@chunhtai What do you think of [bug: Fix popping with a shell route](https://github.com/flutter/packages/pull/6306/commits/aaf86fc49990da12659f6a0b4873da3420f43e6a) ?
Any feedback on this @chunhtai ?
@polina-c Is there something else you want me to do on this?
> Separating the table from the column using a `.` might be better syntax. I don't think that possible, see this comment https://github.com/doug-martin/nestjs-query/issues/559#issuecomment-713290342
@Piinks @victorsanni Hopefully [Use template and passive voice](https://github.com/flutter/flutter/pull/168311/commits/36101426b96a067d1fa8c007cd4b9437942b114c) is what you expected
I'm a bit confused by the failure of "Linux docs_test" ``` Found unresolved dartdoc directives in /b/s/w/ir/x/w/flutter/dev/docs/doc/flutter/widgets/TreeSliver/addAutomaticKeepAlives.html: {@macro flutter.widgets.AutomaticKeepAlive.example} {@macro flutter.widgets.KeepAlive.example} Found unresolved dartdoc directives in /b/s/w/ir/x/w/flutter/dev/docs/doc/flutter/widgets/TwoDimensionalChildListDelegate/addAutomaticKeepAlives.html: {@macro flutter.widgets.AutomaticKeepAlive.example} {@macro...
I did some digging, it looks like `@macro` inside `@template` is not supported https://github.com/dart-lang/dartdoc/issues/2715 @Piinks should I revert what I did for this comment https://github.com/flutter/flutter/pull/168311#discussion_r2073578116 and use copy and paste?...