VReaperV
VReaperV
There's an issue for it: #850. It is used however, e. g. on map https://users.unvanquished.net/~sweet/pkg/map-citadel_0%2B0.dpk.
> It doesn't work at all so shouldn't we just nuke it? It does sort of work, but there are some issues with it that need to be fixed.
> Why add a GLSL compile macro that's always enabled? The point of those is to build multiple variants of the shader. Also it's possible that grid lighting or deluxe...
I've changed this to actually check if lightgrid/deluxegrid are available. Otherwise it would probably break if the map lacks one.
I changed a bit how this works because #line 0 before #insert was making the line count wrong. Now instead #line -1 is treated as a marker, where `PrintShaderSource()` will...
> Just my personal taste and not a required change, but I would rather not have lines saying #LINE_MARKER_END and #LINE_MARKER_START. To me it's useful because it stands out when...
> Hopefully we can nuke those and replace them with `#insert` I thought of that too, should be pretty easily doable. It would also allow dropping more of the forced...
> I tested and the line numbering for the main file was off. After using 3 `#insert`s, the line numbers were too high by 3. For example the real line...
I believe it affects hit/miss with relation to global orientation of a projectile/trace/melee. For this pr in particular though, network is not affected.
> Not really, I suppose OpenGL buffers can have undefined contents. Yes, `glBufferData()` with a nullptr makes the contents of the buffer undefined.