UE4SS
UE4SS
I'm not going to be able to properly review this because I don't know enough about the operations involved in what this PR is trying to accomplish.
> The build script was using utf8-sig, which adds the BOM signature to the start of text files. We need to be able to ignore that when parsing mods.txt Yes...
> What is the state here? It's quite annoying that the first line is still ignored. I wanted to test the changes, but `open_file_skip_BOM` is not called anywhere. It's used...
> What is the state here? It's quite annoying that the first line is still ignored. I wanted to test the changes, but `open_file_skip_BOM` is not called anywhere. It's used...
I can confirm that this doesn't happen in 3.0.1. I don't know why this happens. I've not found any logic problems in my code. Maybe this is a problem with...
I can see why mods.txt would be better as a standardized format, but I don't see why UE4SS-settings needs to change from ini to json. If there's no actual benefit...
> > I can see why mods.txt would be better as a standardized format, but I don't see why UE4SS-settings needs to change from ini to json. If there's no...
> I'd personally avoid doing the json comment by using the adding a new key hack. Whenever I see that mechanism being used, it screams "I'm misusing the intent of...
> > > I'd personally avoid doing the json comment by using the adding a new key hack. Whenever I see that mechanism being used, it screams "I'm misusing the...
> Our comment templates:  Does this support multi-line comments ? We currently have multi-line comments in the ini file and horizontal scrolling is terrible so I think multi-line comments...