UE4SS

Results 349 comments of UE4SS

I'm not going to be able to properly review this because I don't know enough about the operations involved in what this PR is trying to accomplish.

> The build script was using utf8-sig, which adds the BOM signature to the start of text files. We need to be able to ignore that when parsing mods.txt Yes...

> What is the state here? It's quite annoying that the first line is still ignored. I wanted to test the changes, but `open_file_skip_BOM` is not called anywhere. It's used...

> What is the state here? It's quite annoying that the first line is still ignored. I wanted to test the changes, but `open_file_skip_BOM` is not called anywhere. It's used...

I can confirm that this doesn't happen in 3.0.1. I don't know why this happens. I've not found any logic problems in my code. Maybe this is a problem with...

I can see why mods.txt would be better as a standardized format, but I don't see why UE4SS-settings needs to change from ini to json. If there's no actual benefit...

> > I can see why mods.txt would be better as a standardized format, but I don't see why UE4SS-settings needs to change from ini to json. If there's no...

> I'd personally avoid doing the json comment by using the adding a new key hack. Whenever I see that mechanism being used, it screams "I'm misusing the intent of...

> > > I'd personally avoid doing the json comment by using the adding a new key hack. Whenever I see that mechanism being used, it screams "I'm misusing the...

> Our comment templates: ![image](https://private-user-images.githubusercontent.com/73571427/335630933-6a452a03-f93c-47c5-b5ea-ebdd9825ff21.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTcxNjkzMTMsIm5iZiI6MTcxNzE2OTAxMywicGF0aCI6Ii83MzU3MTQyNy8zMzU2MzA5MzMtNmE0NTJhMDMtZjkzYy00N2M1LWI1ZWEtZWJkZDk4MjVmZjIxLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA1MzElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNTMxVDE1MjMzM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTI5MWRhYzEzYjg4MmZiYWQ5YzliMzBjN2E5ZTM4NzIyYjBjMmI5ZmFiZGI2NGQ1OWRhYTZjZDY0NzBjNDM1OGYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.NTg_zSil_EEtv-sHJblL0j7jdQ4d1MLrJMXgzR5ro0c) Does this support multi-line comments ? We currently have multi-line comments in the ini file and horizontal scrolling is terrible so I think multi-line comments...