Daniel Imms

Results 555 comments of Daniel Imms

@npezza93 new versions should only get published when the addon has changes. Also because of the v5 changes just merged in there might be some breaking changes that issues when...

I believe for canvas it's as easy as making the canvas that the character are drawn to be set to transparent.

Actually maybe this is expected as you can customize cursor color.

Opening for discussion as someone mentioned this in https://github.com/microsoft/vscode/issues/84863, we need to know how other popular terminals handle this case with various cursor types before actioning.

Happens only in dom renderer? https://github.com/microsoft/vscode/issues/84880#issuecomment-555231125

@jerch we should align with how other terminals work with this, probably not a good idea to start arbitrarily modifying colors as that would be confusing and complicate things more.

Seems related to https://github.com/xtermjs/xterm.js/issues/3653 Changing the renderer to dom should work, it will be slower though. I've always had problems reproducing these problems so it's hard for me to fix...

VS Code issue: https://github.com/microsoft/vscode/issues/68262

vscode uses xterm, that's the issue that's been reported over there.

I'm not sure if this ever worked if `InputEvent` fixes the problem, sounds like it might be the same root cause as https://github.com/xtermjs/xterm.js/issues/469 and needs us to move input handling...