Daniel Imms

Results 601 comments of Daniel Imms

@jerch we have nearly unlimited glyph space now that we have multiple atlas pages and page merging, so I don't think we need to worry about that?

If you think it's worth it, the PR is way better than the current state already 🙂

Huh, I didn't know that existed. The extra cost would mainly be when the cursor is blinking, if that could move into the shader so it didn't need buffer updates...

To solve the power problem, maybe we should just detect when the terminal is focused and idle as that's the main case I'm concerned about. Something like a `setTimeout(2 *...

Merging into https://github.com/microsoft/vscode/issues/126209

This was done in https://github.com/microsoft/vscode-jupyter/pull/12107

> This project isn't specifically a high priority from microsofts perspective I imagine This is true, currently we support whatever node.js version VS Code's Electron is on which is currently...

This is already called out in the readme that you need to install some build tools on Windows: https://github.com/microsoft/node-pty#windows

@fabiospampinato do you mean you have an existing `Terminal` object and you want to change the icon and color? This would be a new API request.

> basically this extension is setting the icon and the color when creating each terminal, and it was working fine in the past, but since some recent release apparently it...