xterm.js icon indicating copy to clipboard operation
xterm.js copied to clipboard

Published 20 hours ago • verified publisher icon xtermjs

Cursor is not visible on inverted text

Open Tyriar opened this issue 5 years ago • 7 comments

Here's what it looks like in vscode (before and after 3.13, dom or canvas renderer), it happens in demo the same way (viewing italic text in a markdown file on vim):

Screen Shot 2019-05-10 at 7 45 41 PM

Terminal.app:

Screen Shot 2019-05-10 at 7 46 25 PM

Tyriar avatar May 11 '19 02:05 Tyriar

Actually maybe this is expected as you can customize cursor color.

Tyriar avatar May 11 '19 03:05 Tyriar

Opening for discussion as someone mentioned this in https://github.com/microsoft/vscode/issues/84863, we need to know how other popular terminals handle this case with various cursor types before actioning.

Tyriar avatar Nov 15 '19 17:11 Tyriar

This issue is still closed though, was the intention not to reopen it?

jplatte avatar Nov 18 '19 22:11 jplatte

Happens only in dom renderer? https://github.com/microsoft/vscode/issues/84880#issuecomment-555231125

Tyriar avatar Nov 18 '19 22:11 Tyriar

@Tyriar Could the new luma calc be used to sanitize this?

jerch avatar Nov 18 '19 22:11 jerch

@Tyriar I can reproduce this bug with every possible value for terminal.integrated.rendererType. I've also changed the cursor style from block to underline, and that didn't affect this bug.

jplatte avatar Nov 19 '19 09:11 jplatte

@jerch we should align with how other terminals work with this, probably not a good idea to start arbitrarily modifying colors as that would be confusing and complicate things more.

Tyriar avatar Nov 19 '19 14:11 Tyriar

Still repros:

Image

Tyriar avatar Dec 14 '22 17:12 Tyriar