Daniel Imms

Results 870 comments of Daniel Imms

You should be able to switch between modes at runtime: https://github.com/xtermjs/xterm.js/blob/8ea254bdc798ffcf72cb1b37385af40c747d3fa4/src/Terminal.ts#L489-L499

@flenter as long as screen readers work fine and hover to announce works as well then that sounds good.

> I think it could work if alpha is forced to 1 when using background color as inverted foreground color. In the interest of keeping the API simpler/slimmer I think...

@sukima we're just waiting on a PR for this if you want to work on it. The proposal above is to when the bg color is used as the fg...

I made a comment earlier but deleted it as it wasn't even using your branch... 🤦‍♂ @Eugeny isn't this blocked on https://github.com/xtermjs/xterm.js/issues/2252 for webgl?

We need to translate `transparent` to `#000000` here: https://github.com/xtermjs/xterm.js/blob/8b5c48fe878f830914248e4c1ed78e621deb16c4/addons/xterm-addon-webgl/src/atlas/WebglCharAtlas.ts#L231-L236

@Eugeny I think this should be relatively easy to fix if you want to give it a try: https://github.com/xtermjs/xterm.js/issues/1898#issuecomment-558714261 Basically something like: ``` if (color is transparent) { set to...

Any more steps on the repro as I do this every day in VS Code, maybe related to Electron 14 as we're still on 13?

> Maybe related: > > https://github.com/xtermjs/xterm.js/blob/4222dfb69db98be5b3db65ea135b52d2326b643f/addons/xterm-addon-ligatures/src/index.ts#L57 > > Note that this happen in a thenable, such might get eval'ed late after the inital drawing forcing a second re-rendering. This issue...