Daniel Imms

Results 555 comments of Daniel Imms

Code pointer: https://github.com/xtermjs/xterm.js/blob/cece3db0cb01bfb403d468010b89fb3161fe0b5d/src/common/InputHandler.ts#L1934-L1938

I guess this is just browser behavior, I can't reproduce in VS Code I guess because it doesn't have the CSS rule? I wouldn't expect font-smoothing to do anything after...

> Were there recent changes to the textarea logic/hack done? Not this one https://github.com/xtermjs/xterm.js/pull/2632, that was closed

That line updates the index only when output comes in the buffer is resized: https://github.com/xtermjs/xterm.js/blob/0befb9c2513af83bd1fecf9f8c15b1330a2a70c5/addons/xterm-addon-search/src/SearchAddon.ts#L80-L81 So you should only be seeing this if there are data changes coming in, I...

We're definitely not sending anything for ctrl+shift+6, you can check by running the demo and setting logLevel to debug.

@amurchick do you know where documentation is that specifies what all ctrl+shift+ keys are meant to send?

showkey on Terminal.app shows: - ctrl+shift+6: RS (decimal 30) - ctrl+shift+2: NUL (decimal 0) iterm does as well but other numbers print just the numbers.

This can be handled by the embedder. Since this is afaik not an official VT keybinding I suggest hooking up your own keybindings for this in a custom key event...

Ah you're right, ctrl+shift+2 (ctrl+@) also correctly sends null. Looking at https://www.decisivetactics.com/support/view?article=control-characters, we handle all of them correctly (ctrl+w/t don't work because of browser keys) except for ctrl+@, ctrl+^ and...