Tyler Jones
Tyler Jones
Hey @jonrohan! 👋 By chance, do you have more context on this issue? I see there was a PR linked, but was closed out 🤔
Updated snapshots for storybook story changes!
Thanks for creating this issue @zaviermiller! > Playing around in devtools shows the isolation fix from the PR does work here. Happy to open a PR to fix this! We'd...
Work is now in https://github.com/primer/react/pull/6456.
Hey @joshblack! With `caret` being deprecated, I wanted to create a PR that [removes it entirely (in v38)](https://github.com/github/primer/issues/3541#issuecomment-2363893444). I'm curious if the best course of action is to wait until...
> @TylerJDev for timing on this, would it be helpful to open it when we enter into "pre mode" for v38? Then we could merge it in as-is and go...
I noticed that we directly expose `style` on the `textarea`, as the `...rest` allows for pretty much anything (`style` included). I'm wondering if this change is still worth it? e.g....
This change essentially turns `Overlay` into a "Dialog" in the sense of `role="dialog"` and `aria-modal="true"` being added. A focus trap is also added by default, and is enabled if there...
@primer/engineer-reviewers - Hey team! Would love any additional eyes on this PR, mainly in regards [to my rollout plan](https://github.com/primer/react/pull/4990#issuecomment-2364685393).
> If it is a `role=dialog` and has focus trapping, it should be a `` element with `showModal()` called. > > We should steer away from `useFocusTrap` and use `showModal()`...