Tyler Jones
Tyler Jones
@siddharthkp, yup that should be it!
This PR should be ready for a review! cc: @primer/engineer-reviewers
> How do you feel about this PR now that `inactive` elements are released: [Docs](https://primer.style/components/action-list#inactive-items) | [Story](https://primer.style/react/storybook/?path=/story/components-actionmenu-features--inactive-items) > > Is focusing a disabled item without feedback still the way to...
I wonder if we'd want up/down arrow keys to open the menu if this prop is used. For example, if you set [`openOnFocus` to `false`](https://primer-3b8d52ba54-13348165.drafts.github.io/storybook/?path=/story/components-autocomplete--default&args=openOnFocus:!false) and clear the input field,...
Going to close this PR for now, but may reopen it in the future if we decide we want to add live region support to `FormControl` validation!
@lindseywild, just needs to get reviewed now! [I redid my integration test PR](https://github.com/github/github/pull/325669), and it looks good (outside of flakey tests). Requires some changes in GH for tests: https://github.com/github/github/pull/323711#issuecomment-2098990100. cc:...
Was taking a look at this issue, and I'm a bit unsure of what the expected color should be 🤔 I took a look at the [most recent version of...
Hey team! I was wondering if I could get a review on this PR? For context it's making sure that `disabled` or `hidden` elements are removed from the focus zone...
Yup, this does sound similar to the issue that we fixed in PVC. I'll take a look to see if we can implement the same fix here.
This should be fixed with https://github.com/primer/behaviors/pull/263 merged, and will be available in our next release.