Tyler Jones

Results 72 comments of Tyler Jones

Thanks a ton for the notes and video @siddharthkp, it helps a lot to see where the problem is ✨ The current route is definitely not the best for performance...

Quick update, working on a fix in primer/behaviors: https://github.com/primer/behaviors/pull/429. Basically adding a mutation observer that checks if the start or end sentinels are no longer at the start/end.

@siddharthkp, tested this with the updated behaviors version & very lightly in dotcom (though I couldn't find too many dialogs). Doesn't look like there's much performance hit, as the likelihood...

Thank you for the PR @Hanskrogh! This looks great ✨! I'm wondering, would it be possible for us to add a test in `NavList.test.tsx` so that we ensure that we...

Thanks a ton @Hanskrogh! I'll take a look at the changes before the week is up! Thank you again for the PR! ✨

@siddharthkp, with the idea of us rescoping some of the work needed for `Token` in https://github.com/github/primer/issues/3468, I'm wondering if this PR is good to be shipped? Since [the two are...

@siddharthkp, removed all instances of the prop! Should only consist of the storybook changes now

Tested in gh/gh, and integration tests look good! https://github.com/github/github/pull/341786

Hey @cihad! Just wanted to follow-up and see if you were still working on this PR? I see it's nearly finished, it looks like it just needs a changeset and...

Requires small changes in Dotcom for tests, https://github.com/github/github/pull/348018/commits/833ad355c270f37218f3bcc4071319846b0e552a. Removes empty space that `AvatarStack` previously had. More context at https://github.com/github/memex/issues/16409.