Tyler Jones

Results 70 comments of Tyler Jones

@iansan5653 👋 - Thank you for bringing this up! I totally understand where you're coming from in regards to the error being announced. Currently we utilize `aria-describedby` to link the...

@iansan5653 - I understand what you mean, there's definitely some discovery we'll need to do around this during the a11y engineer review for this component. Even if it's not by...

I believe this PR should resolve this issue: https://github.com/primer/react/pull/4445. Essentially, we could rely on just the `aria-describedby` to link the errors, as most screen readers that we test with should...

> @broccolinisoup Also I am not really sure if I understand this prop. How would consumers know how long they should delay the label? 🤔 I might be missing some...

Hey @camertron 👋 I'm coming back to this to say I recently merged a PR that was in a similar state, and it initially had test failures in dotcom. I...

Should require only one change in Dotcom ([a modification to a test](https://github.com/github/github/pull/324056/commits/97b565c0a44191fb73ac8911052de1aa1ee5c96c)), other than that it appears that the tests related to this change pass.

@lindseywild, this PR is waiting on https://github.com/primer/react/pull/4590 to be merged as it fixes a bug that's breaking CI in this PR. Once it's merged I'll be able to set this...

This is one of many ways to handle how we do required indicators in `FormControl.Label`. Would love any other opinions on how to make this easier for consumers :eyes: More...

@broccolinisoup, I would love your review on this PR while it's still in draft state. I started from your PR and tried to shape it in a way that would...

Wanted to loop back here to plan a potential rollout. Since this PR consists of a change that would revamp the semantics of `ActionList` by default, it could be potentially...