Tyler Jones

Switching this PR to "ready for review". Now that we've added feature flags, I believe we can smoothly release this change and monitor it 🥳 I've tested briefly in Dotcom...

@siddharthkp, @broccolinisoup - Hey y'all! I think this is in a good state for a review! I addressed all of the feedback and we should only need [the changes listed...

Definitely agree. The `` component as it is now could be improved for accessibility. > The US Government CMS design system renders [Spinner](https://design.cms.gov/components/spinner/?theme=core) as a status with hidden "Loading" text....

Hey @mperrotti 👋! With [`live-region-element`](https://github.com/primer/react/blob/main/packages/react/src/internal/components/Announce.tsx) being available, do you think this PR is good to go?

> should I remove the announcements and follow @owenniblock's PVC implementation until we've figured out how to handle multiple announcements? I think that's fair. Unless we can make it opt-in,...

@kendallgassner, In this example yeah! I think that the title prop should be removed from `IconProps`. I'm not entirely sure why it's present here, as it seems to be adding...

Definitely agree, I think it'd be beneficial for us to steer away from using HTML attributes as prop names when there's no direct connection. This would involve a breaking change...

If we did test Primer specific components, would we want to ignore `as` usage and still throw a violation regardless of what value it might have? I'm wondering, are there...

> I removed it that line and saw no changes which really confused me. It looks like when the button is in a loading state, the text is visually hidden...

> @siddharthkp - do you think @TylerJDev 's suggestion will fix our problem? I believe the problem would still persist here if there's no `ariaLabelledBy` being passed. I'd say utilizing...