react icon indicating copy to clipboard operation
react copied to clipboard

Published 20 hours ago • verified publisher icon primer

Popover: Remove the caret

Open TylerJDev opened this issue 1 year ago • 4 comments

Closes https://github.com/github/primer/issues/3432

Removes the caret in Popover.

Changelog

Removed

  • Removes caret prop and associated styles from Popover component

Rollout strategy

  • [ ] Patch release
  • [ ] Minor release
  • [x] Major release; if selected, include a written rollout or migration plan
  • [ ] None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

  • [x] Added/updated tests
  • [x] Added/updated documentation
  • [x] Added/updated previews (Storybook)
  • [ ] Changes are SSR compatible
  • [x] Tested in Chrome
  • [ ] Tested in Firefox
  • [ ] Tested in Safari
  • [ ] Tested in Edge
  • [ ] (GitHub staff only) Integration tests pass at github/github (Learn more about how to run integration tests)

TylerJDev avatar Sep 17 '24 14:09 TylerJDev

🦋 Changeset detected

Latest commit: 8f80d76abeaa1c5763e71075fd588458917702a9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Sep 17 '24 14:09 changeset-bot[bot]

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 97.12 KB (-0.36% 🔽)
packages/react/dist/browser.umd.js 97.46 KB (-0.23% 🔽)

github-actions[bot] avatar Sep 17 '24 14:09 github-actions[bot]

Hey @joshblack! With caret being deprecated, I wanted to create a PR that removes it entirely (in v38). I'm curious if the best course of action is to wait until v37 is fully shipped, then to open this PR up for reviews/merging?

TylerJDev avatar Sep 26 '24 14:09 TylerJDev

Yeah that works @TylerJDev! We did a similar thing for MarkdownEditor this time and I bet it would work for this too

joshblack avatar Sep 26 '24 15:09 joshblack

@TylerJDev for timing on this, would it be helpful to open it when we enter into "pre mode" for v38? Then we could merge it in as-is and go through that route. I think I misspoke earlier when I said open after v37 is merged since this would need to be in the RC for v38 versus being able to land in v37

joshblack avatar Oct 22 '24 20:10 joshblack

@TylerJDev for timing on this, would it be helpful to open it when we enter into "pre mode" for v38? Then we could merge it in as-is and go through that route. I think I misspoke earlier when I said open after v37 is merged since this would need to be in the RC for v38 versus being able to land in v37

Makes sense! I'll put this back into draft until then 😄

TylerJDev avatar Oct 22 '24 20:10 TylerJDev

Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days.

github-actions[bot] avatar Dec 23 '24 16:12 github-actions[bot]

Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days.

github-actions[bot] avatar Feb 21 '25 17:02 github-actions[bot]

Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days.

github-actions[bot] avatar Apr 22 '25 19:04 github-actions[bot]