react icon indicating copy to clipboard operation
react copied to clipboard

Token: Add text alternative to close control

Open TylerJDev opened this issue 1 year ago • 3 comments

Closes https://github.com/github/primer/issues/3582 https://github.com/github/primer/issues/3443

Changelog

New

  • Add new prop removeButtonLabel

Changed

  • Moved visually hidden text into token container

Removed

Rollout strategy

  • [x] Patch release
  • [ ] Minor release
  • [ ] Major release; if selected, include a written rollout or migration plan
  • [ ] None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

  • [ ] Added/updated tests
  • [x] Added/updated documentation
  • [ ] Added/updated previews (Storybook)
  • [ ] Changes are SSR compatible
  • [x] Tested in Chrome
  • [ ] Tested in Firefox
  • [ ] Tested in Safari
  • [ ] Tested in Edge
  • [ ] (GitHub staff only) Integration tests pass at github/github (Learn more about how to run integration tests)

TylerJDev avatar Jul 31 '24 13:07 TylerJDev

⚠️ No Changeset found

Latest commit: 08a944817d17e3842649914c2622a3e4e536ac7f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Jul 31 '24 13:07 changeset-bot[bot]

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 97.05 KB (-0.02% 🔽)
packages/react/dist/browser.umd.js 97.46 KB (-0.01% 🔽)

github-actions[bot] avatar Jul 31 '24 13:07 github-actions[bot]

@siddharthkp, with the idea of us rescoping some of the work needed for Token in https://github.com/github/primer/issues/3468, I'm wondering if this PR is good to be shipped? Since the two are intertwined, I was going to work towards adding more changes to Token in that issue, as the additions in this PR wouldn't need to be changed.

TylerJDev avatar Aug 20 '24 14:08 TylerJDev

@siddharthkp, removed all instances of the prop! Should only consist of the storybook changes now

TylerJDev avatar Sep 11 '24 17:09 TylerJDev

:wave: Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/341786

primer-integration[bot] avatar Sep 12 '24 12:09 primer-integration[bot]

Tested in gh/gh, and integration tests look good! https://github.com/github/github/pull/341786

TylerJDev avatar Sep 12 '24 15:09 TylerJDev